Make sure inner classes are checked first #15527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will produce better diagnosis messages. This is because Dotty only show the first error detected for the same line to end users. If we check inner classes first, the scope of the error is restricted to the inner class whenever possible (instead of involving the outer class).
olhotak
approved these changes
Jun 27, 2022
Co-authored-by: Ondřej Lhoták <olhotak@uwaterloo.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure inner classes are checked first
This will produce better diagnosis messages. This is because Dotty only shows the first error
detected for the same line to end users. If we check inner classes first, the scope of the
error is restricted to the inner class whenever possible (instead of involving the outer class).