Reject all explicitly written type references with bad bounds #15577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... except for type parameters, since these will need to be instantiated with good types themselves. Fixes further unsoundness examples added to neg/i15569.scala.
dwijnand
reviewed
Jul 4, 2022
Flag already creations of type that have possibly conflicting bounds. Creation sites are - type declarations other than type parameters - bindings in type patterns
Don't check bounds for type definitions in abstract classes, traits, or refinements. Bounds violations will be detected when values of these types are created.
and fix two other tests
odersky
commented
Jul 9, 2022
dwijnand
reviewed
Jul 9, 2022
dwijnand
approved these changes
Jul 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reject type definitions or bound types in patterns that have possibly conflicting bounds.
However, we can suppress checks for type parameters, since these will need to be instantiated
with good types themselves. We can also suppress checks for members of abstract classes
or traits or types in refinements since in each case these can be accessed only by selecting
from a concrete value, and bounds are checked when such a value is created.
Fixes further unsoundness examples added to neg/i15569.scala.
Fixes #15578
Fixes #15575
Fixes #15609