Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underline assignment correctly in error message #15584

Merged
merged 7 commits into from
Jul 8, 2022

Conversation

liufengyun
Copy link
Contributor

@liufengyun liufengyun commented Jul 4, 2022

Underline assignment correctly in error messages

It also reduces the warning in PatternMatcher in bootstrapping.

@liufengyun liufengyun marked this pull request as ready for review July 4, 2022 18:23
@olhotak
Copy link
Contributor

olhotak commented Jul 7, 2022

Did reverting the expensive eager promotion of field initializers not affect any tests? What code example was eager promotion of fields motivated by?

@liufengyun
Copy link
Contributor Author

Did reverting the expensive eager promotion of field initializers not affect any tests? What code example was eager promotion of fields motivated by?

It's motivated by the code in patternMatcher. The latest commit solves the problem differently. I'll minimize the code from patternMatcher and add it as a test.

@olhotak olhotak merged commit 80f67df into scala:main Jul 8, 2022
@olhotak olhotak deleted the fix-init-error branch July 8, 2022 08:49
@Kordyjan Kordyjan added this to the 3.2.1 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants