Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid assertion failure for illegal trait inheritance #15631

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Avoid assertion failure for illegal trait inheritance #15631

merged 1 commit into from
Jul 11, 2022

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jul 9, 2022

Fixes #15629

@odersky odersky requested a review from som-snytt July 10, 2022 08:03
som-snytt
som-snytt approved these changes Jul 10, 2022
View reviewed changes
Copy link
Contributor

@som-snytt som-snytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified manually that it errors normally now. TIL child annotation. Thanks!

@som-snytt
Copy link
Contributor

Also verified that it was not REPL-specific: compiling the children in separate sources but same run hits the same test, naturally.

@dwijnand dwijnand merged commit 1fb83bd into scala:main Jul 11, 2022
@dwijnand dwijnand deleted the fix-15629 branch July 11, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@som-snytt som-snytt som-snytt approved these changes

Assignees

@som-snytt som-snytt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Second child of sealed trait in REPL on separate lines crashes
3 participants
@odersky @som-snytt @dwijnand