REPL goes through a phase #15663
Merged
REPL goes through a phase #15663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
issue/13885-repl-parser-more-phaselike
branch
2 times, most recently
from
6add4c6
to
592f228
Compare
|
Oh man, red ❌ ? It's literally "just a phase"! |
An initial parser phase is a no-op but lets users see their snippet. A repl phase performs code wrapping. Repl `State` is attached to the compilation unit tree.
som-snytt
force-pushed
the
issue/13885-repl-parser-more-phaselike
branch
from
592f228
to
5f4653d
Compare
dwijnand
approved these changes
Jul 26, 2022
|
To comment more, I previously did something similar for scala 2 REPL, where instead of "pre-wrapping" or "pre-packaging", a phase does that work. That was pre-empted by the "repl frontend" refactor. But I hope it helps with future innovation by looser coupling of concerns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial parser phase is a no-op but lets users see their snippet.
A repl phase performs code wrapping.
Repl
Stateis attached to the compilation unit tree.Fixes #13835