Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid adding NoSymbol to gadt constraints in TypeOps.instantiateToSubType #15965

Merged
merged 1 commit into from
Sep 4, 2022
Merged

Avoid adding NoSymbol to gadt constraints in TypeOps.instantiateToSubType #15965

merged 1 commit into from
Sep 4, 2022

Conversation

KacperFKorban
Copy link
Member

fixes lampepfl#15964

odersky
odersky approved these changes Sep 4, 2022
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KacperFKorban KacperFKorban marked this pull request as ready for review September 4, 2022 16:14
@KacperFKorban KacperFKorban merged commit 9c2e3d9 into scala:main Sep 4, 2022
@KacperFKorban KacperFKorban deleted the fix-i15964 branch September 4, 2022 16:21
@dwijnand
Copy link
Member

dwijnand commented Sep 5, 2022

Nice one, thank you!

@Kordyjan Kordyjan added this to the 3.2.1 backports milestone Sep 15, 2022
@Kordyjan Kordyjan added the backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" label Sep 15, 2022
@Kordyjan Kordyjan mentioned this pull request Sep 15, 2022
Merged
Kordyjan added a commit that referenced this pull request Sep 15, 2022
@Kordyjan
Backport "Avoid adding NoSymbol to gadt constraints in TypeOps.instan…
e7f45a3 
…tiateToSubType" (#16047)

Backports #15965
@Kordyjan Kordyjan added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Sep 15, 2022
@Kordyjan Kordyjan modified the milestones: 3.2.1 backports, 3.2.2 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

Assignees
No one assigned
Labels
backport:done This PR was successfully backported.
Projects
None yet
Milestone
3.2.2
Development

Successfully merging this pull request may close these issues.

AssertionError when pattern matching on element of dependent type member type
4 participants
@KacperFKorban @dwijnand @odersky @Kordyjan