[SemanticDB] fix regression in type apply synthetics #16031
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the regressions in SemanticDB's TypeApply synthetics introduced by #15877
Previously, we relies on
Scala2
flag for filtering out some synthetics, which isn't reliable for SemanticDB (that's why the capture checking made a change in how the compiler put flags to symbols and the regression occurred).This PR fixes the regression by re-implements TypeApply synthetics without using
Scala2
flag.(also fix scalameta/metals#4372)
Probably, it makes more sense to compare the
metac.expect
's diff from 53e1adc which was something before the regression.diff from 53e1adc
git diff 53e1adc783fbe1bdc0636b19c24244617cbb2552 HEAD tests/semanticdb/metac.expect