Fix #15107: Avoid re-emitting a LineNumber after only LabelNodes. #16813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was already some deduplication code to avoid consecutive `LineNumber` nodes. However, it can happen that `LabelNode`s appear in-between. In that case, we also want to deduplicate the `LineNumber`s, since labels do not actually contribute to the final bytecode.
sjrd
force-pushed
the
no-duplicate-linenumbers-in-bytecode
branch
from
5df222f
to
b9b3ed5
Compare
dwijnand
approved these changes
Feb 3, 2023
|
It basically overlaps. Virtually every method had this extra line number at the start, as shown by the existing test changes. (to be clear: that's every test that had |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was already some deduplication code to avoid consecutive
LineNumbernodes. However, it can happen thatLabelNodes appear in-between. In that case, we also want to deduplicate theLineNumbers, since labels do not actually contribute to the final bytecode.