Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove the duplicate parameter when generating the scaladoc. #17097

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

Dedelweiss
Copy link
Contributor

@Dedelweiss Dedelweiss commented Mar 13, 2023

When generating Scaladoc, a duplicate of the parameter appears at the beginning of each signature.
The solution here was to remove this line, as the parameter is already present in the argsSig value.

Before :
Screenshot 2023-03-13 at 15 25 43

After :
Screenshot 2023-03-13 at 15 24 05

I didn't do a test because I don't think there is one (or I couldn't find it). But if needed, a next PR or a next commit to add them can be done.

Fixes: #16647

@Dedelweiss Dedelweiss marked this pull request as ready for review March 14, 2023 09:16
@Dedelweiss Dedelweiss changed the title Remove the duplicate parameter when generating the scaladoc. Fix: Remove the duplicate parameter when generating the scaladoc. Mar 14, 2023
Copy link
Member

@KacperFKorban KacperFKorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Looks good.

I didn't do a test because I don't think there is one (or I couldn't find it).

I think that we don't test extension signatures in scaladoc. (Though we probably should, since I'm 99% sure that this is a regression)

@KacperFKorban KacperFKorban merged commit 6e5be23 into scala:main Mar 15, 2023
@Dedelweiss Dedelweiss deleted the duplicated_extension branch March 15, 2023 13:52
@Kordyjan Kordyjan added this to the 3.3.1 milestone Aug 2, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicated extension receiver in scaladoc
3 participants