Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #11541: Specialize ClassTag[T] in exhaustivity check #17385

Merged
merged 1 commit into from
May 4, 2023
Merged

Fix #11541: Specialize ClassTag[T] in exhaustivity check #17385

merged 1 commit into from
May 4, 2023

Conversation

liufengyun
Copy link
Contributor

Fix #11541: Specialize ClassTag[T] in exhaustivity check

@liufengyun liufengyun marked this pull request as ready for review May 2, 2023 05:26
@nicolasstucki
Copy link
Contributor

We should also make it work for TypeTest or open a different issue. See #11541 (comment).

@liufengyun
Copy link
Contributor Author

We should also make it work for TypeTest or open a different issue. See #11541 (comment).

It seems that already works: #12059

@dwijnand dwijnand merged commit be32eb9 into scala:main May 4, 2023
@dwijnand dwijnand deleted the fix-11541 branch May 4, 2023 09:05
@Kordyjan Kordyjan added this to the 3.3.1 milestone Aug 1, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

@nicolasstucki nicolasstucki Awaiting requested review from nicolasstucki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.1
Development

Successfully merging this pull request may close these issues.

incorrect union type exhaustive match warning with ClassTag
4 participants
@liufengyun @nicolasstucki @dwijnand @Kordyjan