Only transform the body of the quote with QuoteTransformer #17451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
approved these changes
May 10, 2023
| QuoteTransformer().transform(tree) | ||
| case tree: Quote => | ||
| val body1 = QuoteTransformer().transform(tree.body)(using quoteContext) | ||
| cpy.Quote(tree)(body = body1) | ||
| case tree: DefDef if tree.symbol.is(Inline) => | ||
| // Quotes in inlined methods are only pickled after they are inlined. |
There was a problem hiding this comment.
What happens if I have a quote in an inline def in a class in a quote? 🤔
There was a problem hiding this comment.
I assume you mean something like
'{
class Foo:
inline def f = '{ ... }
}In that case the inline def should be rejected when typing. I will check that this is correctly handled.
There was a problem hiding this comment.
We fail correctly with
5 | inline def f(using Quotes) = '{ 1 }
| ^
| inline def cannot be within quotesThere was a problem hiding this comment.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.