Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the behavior of auto-loading credentials chain on S3 #912

Closed
eddyxu opened this issue May 29, 2023 · 2 comments · Fixed by #917
Closed

Fix the behavior of auto-loading credentials chain on S3 #912

eddyxu opened this issue May 29, 2023 · 2 comments · Fixed by #917
Assignees
@chebbyChefNEQ
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed rust Rust related tasks

Comments

@eddyxu
Copy link
Contributor

eddyxu commented May 29, 2023

Problem Statement

Currently, Lance does not support a "default chain of credentials lookups", which makes the experience on AWS bad.

AWS rust sdk has the desired functionalty
https://docs.rs/aws-config/latest/aws_config/default_provider/credentials/struct.DefaultCredentialsChain.html

Not sure how to integrate into object_store rust crate yet.
@eddyxu eddyxu added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed rust Rust related tasks labels May 29, 2023
@changhiskhan
Copy link
Contributor

There was a thread in Arrow-rs (i forgot where) that talks about how pulling in the AWS SDK makes the crate really big / complicated. I don't remember whether it was on github or discord. But it's something to watch out for.

@chebbyChefNEQ
Copy link
Contributor

quick note: object_store only recently exposed the configurbility of credentials field apache/arrow-rs#4235

Going to need to upgrade arrow-rs for this one

@chebbyChefNEQ chebbyChefNEQ mentioned this issue May 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chebbyChefNEQ chebbyChefNEQ

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed rust Rust related tasks
Projects
None yet
Milestone
No milestone
3 participants
@eddyxu @changhiskhan @chebbyChefNEQ