-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add default extensions to PHP 8.0 services #53
Re-add default extensions to PHP 8.0 services #53
Conversation
I think this should be good to merge, going to wait until #72 is in. |
@reynoldsalec with #72 merged the 3.6.0 pre-release out I merged those changes in to this branch just to make sure my changes are still working. Looks like they are locally. Would you like me to test if these same changes can be made to the new 8.1 services as well (and update the branch if so)? |
That would be awesome @cdubz, thanks for poking me on this, once you get those in let's get 'er merged, we're going to try and do another release in two weeks, so at the latest it should go out then if not sooner. |
@reynoldsalec none of the relevant extensions have specifically made a release for PHP 8.1 support (not really surprising) but none of them appear to have any 8.1 issues reported. I was able to use the 3.6.0 pre-release to build an 8.1 container with all four services (apcu, oauth, imagick, memcached) installed and enabled. Imagemagick and memcached appear to work fine in my regular environment (where I use them). I also did some manual testing just using some of the functions provided by oauth and apcu (I don't use either of them normally) and they seem to work fine as well. I think this is good to go 👍 |
Awesome, thanks @cdubz! |
imagick has been re-enabled in PHP 8.0 per lando/legacy-cli#53
imagick has been re-enabled in PHP 8.0 per lando/legacy-cli#53
This is a follow up to lando/lando#2717 -- the extensions that were removed as part of that PR all* now support PHP 8.0 and can be re-enabled.
* memcached is little murky. I was able to build and test memcached successfully with PHP 8.0 in my environment but the latest version still only has PHP 8.0 tests but not official support. See php-memcached-dev/php-memcached#466 and e.g. laminas/laminas-cache-storage-adapter-memcached#13, oerdnj/deb.sury.org#1496 (where some packages are moving forward as is). Not sure if there is another option here or if this needs to remain unsupported...