Updates the location the binding.pem is downloaded to for Lockr support #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this looks good to me |
pirog
added a commit
that referenced
this pull request
Feb 23, 2021
|
@cellar-door @nullvariable im going to close this in favor of #2876 which I THINK will get us where we want to go. If i'm wrong about that i'll owe you both a beer 🍺 |
pirog
added a commit
that referenced
this pull request
Feb 23, 2021
#2859: Allow access to pantheon binding.pem from new location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small update to point the download of the binding.pem to the correct folder where Lockr can find it. This is related to https://github.com/lando/lando/issues/2855 in that without the PANTHEON_BINDING not being defined Lockr ceases to work, however we are moving off using that constant and this will be the fix for that issue.