Linux .deb packaging - postrm is removing user configuration from home directory!?

[frederickjh]

Hi!
In examining the .deb of the newest version of Lando I found that on line 13 of postrm the user configuration for Lando is being removed from their home directory.

rm -rf "$HOME/.lando"

This does not seem like it is correct. Programs should not be deleting a user's configuration for them that is in their home directory.

If a user installs Lando then changes their personal configuration then uninstalls it to install a new version they would lose all their configuration changes. This is not nice for the user.

Please consider removing this from the postrm script.

Thanks for your consideration of this!
Frederick

[pirog]

@frederickjh, im guessing this is a hold over from our older kalabox project which sadly required this for upgrading.

Feel free to submit a PR that removes the line and note that it looks like we also do this on OSX
https://github.com/lando/lando/blob/master/installer/osx/uninstall.sh#L26

[frederickjh]

@pirog I created pull request #475 to fix this issue for Linux and also for OSX.

[pirog]

Awesome! Merged this in and will roll it out in our next release.