[nodejs] CLI container doesn't respect service overrides

[vincenzo]

Bug Report

• Lando: v3.0.0-beta.31
• OS: macOS High Sierra 10.13.1 (Darwin iDumbo 17.2.0 Darwin Kernel Version 17.2.0: Fri Sep 29 18:27:05 PDT 2017; root:xnu-4570.20.62~3/RELEASE_X86_64 x86_64)

My .lando.yml:

name: panda

proxy:
  panda:
    - panda.lndo.site

services:
  panda:
    type: node
    build:
      - "cd /app/ && npm install"
    command: cd /app/ && npm run dev
    overrides:
      services:
        image: node:8.9.3
        environment:
          PORT: 80
          
tooling:
  npm:
    service: panda_cli

When provisioning this, you get:

Pulling panda_cli (node:latest)...
Pulling panda (node:8.9.3)...

The expected behaviour would be to have both on node:8.9.3. I have double checked that they are actually different by ssh-ing into the individual containers.

Also, please note that, according to the docs, the following section:

services:
  panda:
    type: node

should actually be

services:
  panda:
    type: node:custom

but when specifying :custom I get the following error (repeatedly, I guess at each 'pull' attempt):

ERROR: manifest for node:custom not found

This bug doesn't strictly prevent me from using Lando, but it is an impediment as it doesn't allow me to have the same nodejs version on Lando as the one I currently have on Platform.sh, where I deploy the apps for production.

[pirog]

@vincenzo yeah i think this is a good call. I'm guessing you can probably provide overrides by explicitly targeting the cli container but seeing as that happens behind the scenes i think its reasonable that the cli container inherit overrides from the main container while also maintaining its own overrideability

[vincenzo]

I remember trying to target the _cli service directly for overrides, but didn’t work (cannot remember what it was now). Either way, as you say, the _cli should simply inherit the overrides ogni the parent service.