Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary highlight (bgBlack) makes the text unreadable #2302

Closed
pendashteh opened this issue May 29, 2020 · 5 comments
Closed

Unnecessary highlight (bgBlack) makes the text unreadable #2302

pendashteh opened this issue May 29, 2020 · 5 comments
Assignees
Labels
feature Requesting that Lando do something new

Comments

@pendashteh
Copy link

This is a quick fix which will improve readibility of the printed messages.

In the welcome message, there are certain pieces that are styled with a black background (bgColor).

That makes it impossible to read the text.

The solution is to simply not do that. It's not good practice to touch the background color in Terminal.

Definition:

const codeMe = text => chalk.bgBlack.italic(text);

In-code comment:
5dafa1d#r39537262

@pendashteh pendashteh added the feature Requesting that Lando do something new label May 29, 2020
@pirog
Copy link
Member

pirog commented May 29, 2020

@pendashteh i can read it perfectly fine so maybe "impossible" is not the word you want.

@pendashteh
Copy link
Author

@pirog fair enough. Still, I consider it an issue if it's not readable on a standard Ubuntu terminal. Screenshot below:
https://imgur.com/a/1IB4gan
https://imgur.com/V54Y31j (after selecting the text)

The background color is not adding much value, however it makes it very hard to read for some users.

@pirog
Copy link
Member

pirog commented May 29, 2020

There we go! #2302 (comment) is an issue report i can get behind.

@pendashteh
Copy link
Author

I came across an example where the highlight works perfectly well for me.

`These only ${italicize('may')} be a problem.`,

Defined as bellow:

const italicize = name => chalk.italic(name);

Screenshots below:
https://imgur.com/a/6BHf8RY

@pirog pirog self-assigned this Jun 3, 2020
@pirog pirog added this to the 3.0.x-JUNE2020 milestone Jun 3, 2020
@pirog
Copy link
Member

pirog commented Jun 4, 2020

Alright this will be fixed in the next release

@pirog pirog closed this as completed Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Requesting that Lando do something new
Projects
None yet
Development

No branches or pull requests

2 participants