Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates/php8.4 #144

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Updates/php8.4 #144

merged 2 commits into from
Nov 26, 2024

Conversation

rubenvarela
Copy link
Collaborator

Bare minimum self-checks

What do you think of a person who only does the bare minimum?

  • I've updated this PR with the latest code from main
  • I've done a cursory QA pass of my code locally
  • I've ensured all automated status check and tests pass
  • I've connected this PR to an issue

Pieces of flare

  • I've written a unit or functional test for my code
  • I've updated relevant documentation it my code changes it
  • I've updated this repo's README if my code changes it
  • I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs)

Finally

If you have any issues or need help please join the #contributors channel in the Lando slack and someone will gladly help you out!

You can also check out the coder guide.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for lando-php failed. Why did it fail? →

Name Link
🔨 Latest commit 6d1fb22
🔍 Latest deploy log https://app.netlify.com/sites/lando-php/deploys/6740c66e1109d90008407293

@AaronFeledy AaronFeledy merged commit 59d3f9d into main Nov 26, 2024
60 of 88 checks passed
@AaronFeledy AaronFeledy deleted the updates/php8.4 branch November 26, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants