Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using multiple backends does not work. #3

Open
freality opened this issue Feb 10, 2022 · 0 comments
Open

Using multiple backends does not work. #3

freality opened this issue Feb 10, 2022 · 0 comments

Comments

@freality
Copy link

freality commented Feb 10, 2022

VARNISH_BACKEND_HOST: options.backends.join(' '),

The wodby/varnish expects a valid hostname for its VARNISH_BACKEND_HOST env variable (used here: https://github.com/wodby/varnish/blob/0e0ad4cea019dda531dab37325daf6be36c91763/templates/includes/backend.vcl.tmpl#L4). But the builder code concatenates the configured backends into a space delimited string. This results in a non-valid hostname.

I need to be able to address multiple varnish backends in my project. But looking at thewodby/varnish varnish config, it appears it is not possible in .lando.yml service config alone.

Although, It'd be great if the entire service didn't break when multiple backends are defined. As Lando also uses the backends configuration in its depends_on conf.

If only using the first defined backend is a serviceable solution? I'd be happy to submit the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant