Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(member): only render member data if provided #27

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Conversation

mtdvlpr
Copy link
Collaborator

@mtdvlpr mtdvlpr commented Feb 28, 2024

If email and commits is not provided (in my case), the avatar title becomes Manoah <undefined> - NaN commits.

This PR fixes that and only adds the email/commits part if that data is provided.

Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for vitepress-theme-default-plus ready!

Name Link
🔨 Latest commit 49f624c
🔍 Latest deploy log https://app.netlify.com/sites/vitepress-theme-default-plus/deploys/65df3fe9ccf6bb00083c3c0f
😎 Deploy Preview https://deploy-preview-27--vitepress-theme-default-plus.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pirog pirog merged commit 750b539 into lando:main Feb 29, 2024
6 checks passed
@pirog
Copy link
Member

pirog commented Feb 29, 2024

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants