Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat[community]: Add rerank solution to existing IBM community implementation #7200

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat[community]: Add rerank solution to existing IBM community implementation #7200

wants to merge 4 commits into from

Conversation

FilipZmijewski
Copy link
Contributor

@FilipZmijewski FilipZmijewski commented Nov 13, 2024 •
edited
Loading

Extend existing implementation

  • Create rerank implementation
  • Provide tests for this implementation
  • Provide documentation for rerank
  • Fix couple tests

@FilipZmijewski
Fixed missing tool_choice in call options of chat (#30)
fe4be19
@FilipZmijewski
Add rerank implementation to existing IBM community implementation (#25)
6028378 
Extend existing implementation

- rename variables to camelCase
- remove default values for model
- Update and remove some tests
- update urls in documentation, shrink outputs
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Nov 13, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Nov 22, 2024 9:48am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Nov 22, 2024 9:48am

@dosubot dosubot bot added auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder auto:improvement Medium size change to existing code to handle new use-cases labels Nov 13, 2024
jacoblee93
jacoblee93 reviewed Nov 17, 2024
View reviewed changes
libs/langchain-community/src/retrievers/ibm.ts Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a retriever, should be under in /src/document_transformers/ibm_rerank.ts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, in python this would be in document compressors which is why I propose we create a new folder for that as it would be in python community. Am I right?

@jacoblee93 jacoblee93 added the in progress PRs that are in progress but not ready to merge label Nov 17, 2024
@FilipZmijewski
Add fixes according to review (#32)
8e8e8b5 
* Add fixes according to review
* Upload config info
@FilipZmijewski
Copy link
Contributor Author

FilipZmijewski commented Nov 20, 2024 •
edited
Loading

@jacoblee93 Do you have any news about this? Are we proceeding like that?

@jacoblee93
Copy link
Collaborator

Hey @FilipZmijewski, yes let's add here. Thanks for flagging - will need to add to docs properly but I can do that.

@FilipZmijewski
Fix notebooks
cec9e1c 
* Fix notebook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacoblee93 jacoblee93 jacoblee93 left review comments

Assignees
No one assigned
Labels
auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder auto:improvement Medium size change to existing code to handle new use-cases in progress PRs that are in progress but not ready to merge size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FilipZmijewski @jacoblee93