Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Enhance Workflow Nodes for Clearer Exception Handling #10207

Closed
14 of 15 tasks
laipz8200 opened this issue Nov 2, 2024 · 0 comments
Closed
14 of 15 tasks

Refactor: Enhance Workflow Nodes for Clearer Exception Handling #10207

laipz8200 opened this issue Nov 2, 2024 · 0 comments
Labels
🌊 feat:workflow Workflow related stuff. good first issue Good first issue for newcomers

Comments

@laipz8200
Copy link
Member

laipz8200 commented Nov 2, 2024

Self Checks

  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • [FOR CHINESE USERS] 请务必使用英文提交 Issue,否则会被关闭。谢谢!:)
  • Please do not modify this template :) and fill in all the required fields.

1. Is this request related to a challenge you're experiencing? Tell me about your story.

In order to improve the clarity and maintainability of exception handling in our workflow nodes, the following changes are proposed:

  1. Create Specific Error Types for Each Node: Define unique error types for individual nodes to avoid using generic exceptions such as ValueError. This change will help in distinguishing different failure scenarios more precisely.

  2. Return NodeRunResult with Exception Details: When possible, return a NodeRunResult that includes comprehensive exception information rather than raising uncategorized exceptions without context. This approach provides better context for error handling and improves debugging and traceability throughout the workflow.

Implementing these changes will contribute to more robust error handling, enhancing both developer experience and system reliability.

2. Additional context or comments

3. Can you help us with this feature?

  • I am interested in contributing to this feature.
@laipz8200 laipz8200 self-assigned this Nov 2, 2024
@laipz8200 laipz8200 removed their assignment Nov 2, 2024
@laipz8200 laipz8200 added the good first issue Good first issue for newcomers label Nov 2, 2024
@dosubot dosubot bot added the 🌊 feat:workflow Workflow related stuff. label Nov 3, 2024
@laipz8200 laipz8200 removed the good first issue Good first issue for newcomers label Nov 3, 2024
@laipz8200 laipz8200 self-assigned this Nov 3, 2024
@laipz8200 laipz8200 added the good first issue Good first issue for newcomers label Nov 6, 2024
@laipz8200 laipz8200 removed their assignment Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 feat:workflow Workflow related stuff. good first issue Good first issue for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant