Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When copying an iteratation node in a workflow, the edges between the nodes inside the copied iteration node are lost. #12689

Open
5 tasks done
ihaichao opened this issue Jan 13, 2025 · 1 comment · May be fixed by #12692
Open
5 tasks done
Labels
🐞 bug Something isn't working 🌊 feat:workflow Workflow related stuff.

Comments

@ihaichao
Copy link

Self Checks

  • This is only for bug report, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • [FOR CHINESE USERS] 请务必使用英文提交 Issue,否则会被关闭。谢谢!:)
  • Please do not modify this template :) and fill in all the required fields.

Dify version

0.15.0

Cloud or Self Hosted

Self Hosted (Docker)

Steps to reproduce

Copying an iteratation node in any workflow.

image

✔️ Expected Behavior

The edges between the nodes inside the copied iteration node are exist.

❌ Actual Behavior

The edges between the nodes inside the copied iteration node are lost.

@dosubot dosubot bot added 🌊 feat:workflow Workflow related stuff. 🐞 bug Something isn't working labels Jan 13, 2025
Copy link

dosubot bot commented Jan 13, 2025

@ihaichao Hello! I'm here to help you with any bugs, questions, or contributions while we wait for a human maintainer. Let's work together to solve this issue!

The issue you're experiencing, where edges between nodes inside a copied iteration node are lost, might be related to how the Dify workflow system handles node copying. The function handleNodeIterationChildrenCopy is responsible for copying iteration nodes and their children, but it seems that it might not be preserving the edges between these nodes during the copy process [1].

To address this, you might need to ensure that the edges are also copied and re-established when the nodes are duplicated. This could involve modifying the existing functions or adding new logic to handle the preservation of edges when iteration nodes are copied. Unfortunately, the current documentation and codebase do not provide specific details on how edges are managed during the node copying process, so further investigation or code modification might be necessary to resolve this issue.

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🌊 feat:workflow Workflow related stuff.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant