Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retrieval setting validate #10454

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Conversation

zxhlyh
Copy link
Collaborator

@zxhlyh zxhlyh commented Nov 8, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@zxhlyh zxhlyh requested a review from iamjoel November 8, 2024 07:52
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 8, 2024
@zxhlyh zxhlyh marked this pull request as draft November 8, 2024 07:52
@zxhlyh zxhlyh marked this pull request as ready for review November 12, 2024 06:37
@dosubot dosubot bot added the 🐞 bug Something isn't working label Nov 12, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@zxhlyh zxhlyh merged commit e4d1757 into main Nov 12, 2024
7 checks passed
@zxhlyh zxhlyh deleted the fix/workflow-knowledge-retrieval-validate branch November 12, 2024 06:38
AlwaysBluer pushed a commit to AlwaysBluer/dify that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants