Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:position error when creating segments #10706

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

jarvis2f
Copy link
Contributor

Summary

In the original code, the position of the segments was set using max_position + 1, which could lead to incorrect position calculation in scenarios with multiple concurrent requests or different datasets. Specifically, in a single request, the value of max_position might not have been correctly updated, resulting in an inaccurate calculation of the position for new segments.

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Nov 14, 2024
@crazywoola crazywoola requested a review from JohnJyong November 14, 2024 12:55
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 14, 2024
@crazywoola crazywoola merged commit 5ff02b4 into langgenius:main Nov 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants