Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tvOS broken due to unavailable font #52

Closed
invliD opened this issue May 27, 2016 · 4 comments
Closed

tvOS broken due to unavailable font #52

invliD opened this issue May 27, 2016 · 4 comments
Assignees
@Coeur
Labels
bug
Milestone
2.1.1

Comments

@invliD
Copy link
Contributor

invliD commented May 27, 2016 •
edited
Loading

Commit da3aea3 introduced a bug that prevents TSMarkdownParser from working on tvOS. The font "Georgia-Italic", or Georgia in general, is not available, so tvOS apps crash when instantiating a TSMarkdownParser.

Specifically, [UIFont fontWithName:] returns nil, but nil cannot be the value in an NSDictionary.
@Coeur
Copy link
Collaborator

Coeur commented May 30, 2016

Ah, sorry about that.
Will fix it tonight.

@Coeur Coeur self-assigned this May 30, 2016
@Coeur Coeur added the bug label May 30, 2016
@Coeur Coeur added this to the 2.1.1 milestone May 30, 2016
@Coeur
Copy link
Collaborator

Coeur commented Jun 1, 2016

Any preference to replace Georgia? (note: the System font here is the one for iOS 9)
available alternative fonts for Georgia

@invliD
Copy link
Contributor Author

invliD commented Jun 1, 2016

I think System would be fine.

@Coeur
Copy link
Collaborator

Coeur commented Jun 3, 2016 •
edited
Loading

I'll go with italicSystemFont for quotes.

But Menlo isn't available for watchOS also... The only monospace fonts for watchOS are:
monospace fonts for watchOS

Coeur added a commit to Coeur/TSMarkdownParser that referenced this issue Jun 4, 2016
@Coeur
fix broken compatibility with tvOS laptobbe#52
b505a0d
@Coeur Coeur closed this as completed Jun 4, 2016
Coeur added a commit that referenced this issue Jun 4, 2016
@Coeur
Merge branch 'master' into 3.x
69d39de 
* master:
  italicSystem doesn't exist on OSX
  Fixed Multiline CodeEscaping [#51]
  fix broken compatibility with tvOS #52
  Fix OS X framework target

# Conflicts:
#	CHANGELOG.md
#	TSMarkdownParser.podspec
#	TSMarkdownParser.xcodeproj/project.pbxproj
#	TSMarkdownParser/TSMarkdownParser.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Coeur Coeur

Labels
bug
Projects
None yet
Milestone
2.1.1
Development

No branches or pull requests
2 participants
@invliD @Coeur