Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add percentEscapesUsingEncoding #61

Merged
merged 1 commit into from
Dec 9, 2016
Merged

Conversation

keito5656
Copy link

I think URL encoding is necessary here as well.

@Coeur
Copy link
Collaborator

Coeur commented Dec 7, 2016

Thank you keito,

Autodetection is based on native regular expression [NSDataDetector dataDetectorWithTypes:NSTextCheckingTypeLink error:nil], which probably only detects valid URL. Can you provide an example where this change would be useful?

@Coeur Coeur changed the title add ercentEscapesUsingEncoding add percentEscapesUsingEncoding Dec 7, 2016
@keito5656
Copy link
Author

Thank you for your reply.
I live in Japan. So sometimes I use a URL that contains Japanese.
For example
http://槍ヶ岳山荘.jp

This URL matches Autodetection. However, [NSURL URLWithString:] fails as it is.

@Coeur
Copy link
Collaborator

Coeur commented Dec 8, 2016

Nice catch.
Well, I'll merge it today (after I write a Unit test to confirm this).

@keito5656
Copy link
Author

Thank you Coeur ! 😀

@Coeur Coeur merged commit f4964d7 into laptobbe:master Dec 9, 2016
@Coeur
Copy link
Collaborator

Coeur commented Dec 11, 2016


🎉 Congrats

🚀 TSMarkdownParser (2.1.2) successfully published
📅 December 11th, 07:09
🌎 https://cocoapods.org/pods/TSMarkdownParser
👍 Tell your friends!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants