Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow performance with yarn serve and yarn build after Enso 4.4.0 #352

Closed
3 tasks done
robbykrlos opened this issue Nov 23, 2020 · 5 comments
Closed
3 tasks done

Slow performance with yarn serve and yarn build after Enso 4.4.0 #352

robbykrlos opened this issue Nov 23, 2020 · 5 comments

Comments

@robbykrlos
Copy link

This is a question.

Prerequisites

  • [4.4.0] Are you running the latest version?
  • Are you reporting to the correct repository?
    (enso is made of many specialized packages: https://github.com/laravel-enso)
  • Did you check the documentation?
  • Did you perform a cursory search?

Description

Not sure how you guys run your environments and what OS you are using, but we noticed a slower performance in yarn build and yarn serve - especially in yarn serve with the new Enso 4.4.0 on Windows 10 Pro machines.

This makes it much more slower to observe changes in page when any line change will trigger a ~100 seconds rebuild, mostly hanging on 40%:

image

I've noticed some Vue files had some local styles defined, and thought by removing them will help - but was no significant performance change (at least for one correction).

If you have some ideas we're glad to have a starting point of investigation

@robbykrlos
Copy link
Author

robbykrlos commented Nov 23, 2020

Not saying this is from 4.4.0 code changes - it might be from yarn + windows and triggered not because of recent changes.

In the same time I'm trying: https://stackoverflow.com/questions/40566222/yarn-5x-slower-on-windows

Disabling windows search indexing on your work folder and yarn cache folder as well as disabling windows defender completely or on a folder should give you significant performance boost. I've got 30-50% decrease on similar system with SSD drive, originally timings were as yours.

Disabling it on Yarn cache folder would also give you some speedup. Its location is shown by yarn cache dir command, %USERPROFILE%\Local Settings\Yarn\cache by default.

To disable search indexing on a folder, find it in Explorer, right click, then Properties - General - Advanced, uncheck the "Allow files in this folder to have contents indexed in addition to file properties" checkbox, then Apply the changes.

This performance issue already exists on yarn github (Oct'2016) and is still open to the moment: yarnpkg/yarn#990

@robbykrlos
Copy link
Author

Oh... this ain't looking good. Can be from AV:

yarnpkg/yarn#990

image

@aocneanu
Copy link
Member

Hi @robbykrlos,

We're only using linux & mac so we don't have any helpful input for W... other than switch it:)

@robbykrlos
Copy link
Author

Ok, good. Will close this one. Will return with updates in case we find a solution for windows - may be useful for somebody with the same issue.

@robbykrlos
Copy link
Author

robbykrlos commented Dec 17, 2020

Some updates on this issue : after some days, I had to clean-up node_modules, because of some corrupted files, and some weird errors, and using:

Clean-up yarn cache:
yarn cache clean

Delete all node_modules inner folders. Use "Fast delete":
https://stackoverflow.com/questions/28175200/how-to-delete-node-modules-deep-nested-folder-in-windows

Install RimRaf:
npm install rimraf -g
And in the project folder delete the node_modules folder with:
rimraf node_modules

Install again all node_modules:

yarn install
yarn serve

Build and Serve are now working normally 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants