Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arr helper forwarding calls to Illuminate Arr helper fails for methods with array passed by reference #4

Open
lindyhopchris opened this issue Apr 7, 2021 · 1 comment

Comments

@lindyhopchris
Copy link
Contributor

At the moment the LaravelJsonApi\Core\Support\Arr helper forwards static calls through to the Illuminate\Support\Arr class. This does not work for methods, e.g. forget, where the array is passed by reference. To fix, we will need to implement these methods on our Arr class and mark the value as passed by reference: then forward on to the correct method in the Illuminate class.

@lindyhopchris
Copy link
Contributor Author

Think the best option here is to deprecate forwarding the calls, then remove the forwarding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant