Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error message on expired token #516

Closed
szepeviktor opened this issue Jan 16, 2024 · 4 comments
Closed

No error message on expired token #516

szepeviktor opened this issue Jan 16, 2024 · 4 comments

Comments

@szepeviktor
Copy link

szepeviktor commented Jan 16, 2024

Fortify Version

1.19.0

Laravel Version

10.34.2

PHP Version

8.2.13

Database Driver & Version

MariaDB 10.3.39 on Debian buster amd64

Description

Requesting a new password reset makes the token in the previous one expired.
Clicking on that expired link loads the password reset form but there is no error message.

The "token expired" error message appears only when the user submits the form.
Inspired by @iamgergo

Steps To Reproduce

  1. Request password reset
  2. Request password reset again
  3. Click the link in the first email (that contains the expired token)
Copy link

Thank you for reporting this issue!

As Laravel is an open source project, we rely on the community to help us diagnose and fix issues as it is not possible to research and fix every issue reported to us via GitHub.

If possible, please make a pull request fixing the issue you have described, along with corresponding tests. All pull requests are promptly reviewed by the Laravel team.

Thank you!

@driesvints
Copy link
Member

We'd appreciate a PR to make this more clear, thanks.

@szepeviktor
Copy link
Author

@driesvints Could you ensure me that a PR displaying an error message will get merged?

@driesvints
Copy link
Member

No. Everything depends on the code involved and the complexity. If you really need this and want to be sure, you can always fork the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants