[8.x] Fix model factories (#32865)

* Fix docblocks

* parameter of count is nullable

* Fix dockblock

* Fix docblock

src/Illuminate/Database/Eloquent/Factories/BelongsToManyRelationship.php

@@ -31,7 +31,7 @@ class BelongsToManyRelationship
      * Create a new attached relationship definition.
      *
      * @param  \Illuminate\Database\Eloquent\Factories\Factory  $factory
-     * @param  callable\array  $pivot
+     * @param  callable|array  $pivot
      * @param  string  $relationship
      * @return void
      */

src/Illuminate/Database/Eloquent/Factories/Factory.php

@@ -130,7 +130,7 @@ public function __construct($count = null,
     /**
      * Define the model's default state.
      *
-     * @return static
+     * @return array
      */
     abstract public function definition();
 
@@ -488,10 +488,10 @@ protected function callAfterCreating(Collection $instances, ?Model $parent = nul
     /**
      * Specify how many models should be generated.
      *
-     * @param  int  $count
+     * @param  int|null  $count
      * @return static
      */
-    public function count(int $count)
+    public function count(?int $count)
     {
         return $this->newInstance(['count' => $count]);
     }

tests/Database/DatabaseEloquentFactoryTest.php

@@ -86,6 +86,9 @@ public function test_basic_model_can_be_created()
         $user = FactoryTestUserFactory::new()->create();
         $this->assertInstanceOf(Eloquent::class, $user);
 
+        $user = FactoryTestUserFactory::new()->createOne();
+        $this->assertInstanceOf(Eloquent::class, $user);
+
         $user = FactoryTestUserFactory::new()->create(['name' => 'Taylor Otwell']);
         $this->assertInstanceOf(Eloquent::class, $user);
         $this->assertEquals('Taylor Otwell', $user->name);
@@ -96,6 +99,9 @@ public function test_basic_model_can_be_created()
 
     public function test_make_creates_unpersisted_model_instance()
     {
+        $user = FactoryTestUserFactory::new()->makeOne();
+        $this->assertInstanceOf(Eloquent::class, $user);
+
         $user = FactoryTestUserFactory::new()->make(['name' => 'Taylor Otwell']);
 
         $this->assertInstanceOf(Eloquent::class, $user);