Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Empty paginator still renders #15124

Closed
garygreen opened this issue Aug 29, 2016 · 0 comments
Closed

[5.3] Empty paginator still renders #15124

garygreen opened this issue Aug 29, 2016 · 0 comments

Comments

@garygreen
Copy link
Contributor

garygreen commented Aug 29, 2016

An empty paginator still renders just the disabled prev/next links or showing only 1 page, seems a bit strange considering in Laravel 5.2 it output nothing.

Is it suggested we publish and modify the view or wrap all our ->render() calls in an if statement? There's nothing about this mentioned on the upgrade guide so might catch quite a few people out.

image

It also renders when there is only 1 page, which is different from 5.2:

image

@garygreen garygreen changed the title Empty paginator still renders [5.3] Empty paginator still renders Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant