Builder backwards incompatible

[piotrtheis]

• Laravel Version: #.#.#
• PHP Version: 7.0.8
• Database Driver & Version:

Description:

@taylorotwell LengthAwarePaginator should use custom model collection from newCollection not Collection, even if query result is empty.

from docs

from
to

Steps To Reproduce:

$results = $this->forPage($page, $perPage)->get($columns);

instead of

$results = $total ? $this->forPage($page, $perPage)->get($columns) : new Collection;

in

[vlakoff]

Makes sense to transmit the same class, whether results are empty or not.

If you want to keep the optimization from #14188:

$results = $total
    ? $this->forPage($page, $perPage)->get($columns)
    : $this->model->newCollection();

[GrahamCampbell]

We're open to PRs. :)

[vlakoff]

Submitted #16547.

Though may I suggest to close issues after a PR has been opened? If an issue is worth fixing but is closed, it's easy to forget about it…