[11.11] Cannot bind an instance to a static closure

[rcerljenko]

Laravel Version

11.11.0

PHP Version

8.3.8

Database Driver & Version

MySQL 8.0.37

Description

With a new minor release came this PR that broke factory afterCreating() method.

Issue is happening when a closure function is declared as static (rector does that autmatically for us) in the factory afterCreating() method.

See images below.

Error message:

Our code that uses this method:

Steps To Reproduce

Use a static clusure in factory afterCreating() method.

[crynobone]

Hey there, thanks for reporting this issue.

We'll need more info and/or code to debug this further. Can you please create a repository with the command below, commit the code that reproduces the issue as one separate commit on the main/master branch and share the repository here?

Please make sure that you have the latest version of the Laravel installer in order to run this command. Please also make sure you have both Git & the GitHub CLI tool properly set up.

laravel new bug-report --github="--public"

Do not amend and create a separate commit with your custom changes. After you've posted the repository, we'll try to reproduce the issue.

Thanks!

[rcerljenko]

We don't have to do all of that... You can just change this line in the factory test to declare a static closure instead of non-static one.

https://github.com/laravel/framework/blob/11.x/tests/Database/DatabaseEloquentFactoryTest.php#L271

[driesvints]

Ping @jacob418

[mabdullahsari]

Can confirm:

#51772 (comment)

[driesvints]

Reverted.