[8.x] Change __call factory and relation resolution #33439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve 2 problems we could have using magic
forXX
andhasXX
ofIlluminate\Database\Eloquent\Factories\Factory
1 : Inconsistency of parameter given to
factoryForModel
As described in laravel/ideas#2284, if
App\User
usesIlluminate\Database\Eloquent\Factories\HasFactory
, callingApp\User::factory()
will callFactory::factoryForModel
with'App\User'
whereas callingPostFactory::forUser
will call it with'user'
. IMHO it should always be called with the fully qualified class name.2 : Relations are not always called by related model name
It is common to have relation named by something else than the related model name. For example, if a post belongs to a user, the post relation can be named
author
.This PR allows developer to call
$postFactory()->forAuthor()
to create the post's author.