[9.x] Allow for null handling in custom casts #38039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change to how custom casts are handled. Currently, when
null
is provided to a property that has a custom cast, all array keys present in the response of theset
method are automatically set tonull
regardless of what theset
method does.While a reasonable default, I think it should be better to leave it to the
set
implementation to choose how to deal withnull
values being set. I haven't been able to think of any easy solution to keep the old 'default' behavior, hence a breaking change.Note that the first part of this PR should be non-breaking and is part of #38004.