Add Wrapper for Symfony SentMessage #38803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
I thought of renaming SentMessage. Because there is currently a MessageSent Event and I don't want two classes with really similar names. Any ideas for a better name? Maybe something like SentMail (because PendingMail exists) @kafkiansky why the downvote? |
|
Thanks @Jubeki! |
taylorotwell
added a commit
that referenced
this pull request
Sep 14, 2021
* Implement Symfony Mailer * Apply fixes from StyleCI * Update src/Illuminate/Mail/Message.php Co-authored-by: michael-rubel <contact@observer.name> * Update src/Illuminate/Mail/Message.php Co-authored-by: michael-rubel <contact@observer.name> * Update src/Illuminate/Mail/Message.php Co-authored-by: michael-rubel <contact@observer.name> * Update src/Illuminate/Mail/Message.php Co-authored-by: michael-rubel <contact@observer.name> * Update src/Illuminate/Mail/Message.php Co-authored-by: michael-rubel <contact@observer.name> * Update Array and Log transports * Apply fixes from StyleCI * Fix interface implementation * Update Mailer * Apply fixes from StyleCI * Rename * Remove method * Fix tests * Apply fixes from StyleCI * Work on Mailer tests * type-hint * Fix Mailer tests * Fix more tests * Apply fixes from StyleCI * Migrate Mailgun transport * Migrate Postmark transport * Replace SesTransport * Remove transports from dev dependencies * Allow setting options on esmtp transport * Fix Postmark transport * Fix embedding files * Clarify API transports * Apply fixes from StyleCI * Fix SES transport setup * Add MessageStreamId to Postmark Transport again (#38748) * Update symfony mailer docblocks (#38773) * Update docblocks from Swift Mailer to Symfony Mailer * Make TransportInterface more specific * Add Session Token to SES Transport (#38797) * Update src/Illuminate/Mail/Transport/ArrayTransport.php Co-authored-by: Julius Kiekbusch <jubeki99@gmail.com> * fix docblock * Add Wrapper for Symfony SentMessage (#38803) * Create SentMessage wrapper for Symfony's SentMessage * Wrap Symfony SentMessage * Update Docblocks to Illuminate\Mail\SentMessage * Fix sendMailable * Update SentMessage.php Co-authored-by: Dries Vints <dries@vints.io> Co-authored-by: Taylor Otwell <taylorotwell@users.noreply.github.com> Co-authored-by: michael-rubel <contact@observer.name> Co-authored-by: Julius Kiekbusch <jubeki99@gmail.com> Co-authored-by: Taylor Otwell <taylor@laravel.com> Co-authored-by: Taylor Otwell <taylorotwell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows custom features additions without the need to update Symfony's SentMessage.
All Transports still return a Symfony SentMessage. Only the Mailer will wrap it into our own SentMessage.
This should give us the most flexibility and we still can make use of Symfony's TransportInterface.
I didn't add tests because the decorator currently has the same functions as before.
More functions can be added later on.