Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Replace usage of the optional() helper by the nullsafe operator #38867

Closed
wants to merge 305 commits into from
Closed

[9.x] Replace usage of the optional() helper by the nullsafe operator #38867

wants to merge 305 commits into from

Conversation

felixdorn
Copy link
Contributor

@felixdorn felixdorn commented Sep 19, 2021

Merged into the wrong branch 😄...

JamesFreeman and others added 30 commits November 26, 2020 08:30
# Conflicts:
#	src/Illuminate/Foundation/Application.php
* Flysystem v2

* Dynamic separator for Windows

* Update namespace FTP adapter

* Bump minimum alpha

* Remove ^2.0 constraint from ftp driver

* Update composer.json

* Update composer.json
…rch_path" (#35463)

* Fix terminology in respect to 'schema' vs 'search_path'

* Added support for Comma separated search paths with added test

* Added support for Postgres Variables in search paths with added test

* Fix schema quoting issue and update tests to verify behavior

More specifically, fix issue whereby individual schema paths in an array were quoted twice.

Also, update arguments in tests to verify schema name parsing with vs. without quotes, for both string and array notations.

* Update method to use new "search_path" config key name

Co-authored-by: poppabear8883 <servnx@gmail.com>
Primarily, these changes "normalize" the search_path parsing behavior such that the new parseSearchPath() method returns the same result whether the search_path input is an array (with one or more schemas), a string with one schema, or a string of comma-separated schemas.

This method's presence makes it much simpler to retrieve the search_path as configured on the connection and use it for more complex schema-related grammar construction.
The manner in which object references were parsed in certain scenarios caused methods such as hasTable() to return incorrect results.

Among other issues, the underlying SQL grammar omitted the "table_catalog" (i.e., database) in the WHERE clause, which caused inaccurate results in certain cases, e.g., the method returned true incorrectly because a schema and table with the same name exist in a *different database*.
#35531)

* add passwordTimeout to RequirePassword middleware as a parameter

* Update RequirePassword.php

Co-authored-by: Alin Musat <alin@boostit.com>
Co-authored-by: Taylor Otwell <taylor@laravel.com>
* Default ipAddress column name

* Default macAddress column name
…rch_path (#35567)

Given that the default search_path value in a PostgreSQL installation is '"$user", public', or perhaps just '"$user"', as may be the case if hardened against CVE-2018-1058, it is preferable to account for the possibility that an end-user may wish to configure a PostgreSQL database connection in Laravel to mimic said default.

Now, if '$user' is the first schema in the search_path, the PostgresBuilder will resolve that schema name to the username defined on the database connection whenever appropriate, e.g., in the hasTable() and getColumnListing() methods.
driesvints and others added 27 commits August 26, 2021 17:38
…` type definitions (#38538)

* Adds CI workflow

* Adds phpstan

* Adds work in progress regarding generic collections

* Fixes missing template

* Renames template

* Updates test

* Apply fixes from StyleCI

* Adds work in progress regarding generic collections

* Adds work in progress regarding generic collections

* Adds work in progress regarding generic collections

* Adds work in progress regarding generic collections

* Adds work in progress regarding generic collections

* Styling

* Apply fixes from StyleCI

* Apply fixes from StyleCI

* Adds work in progress regarding generic collections

* Remove work on Models

* Revert "Remove work on Models"

This reverts commit d6c4291.

* Removes `prefer-lowest`

* Removes non needed code on CI job

Co-authored-by: Dries Vints <dries@vints.io>

* Fixes `Eloquent\Collection::load` types

* Adds work in progress regarding generic collections

* Fixes `Eloquent\Collection::load` related methods

Co-authored-by: Taylor Otwell <taylorotwell@users.noreply.github.com>
Co-authored-by: Dries Vints <dries@vints.io>
* Pass null to custom cast set method when value is null

* Add integration test for custom casts on Eloquent Model

* Rename Address class to AddressCast in EloquentModelCustomCastingTest

Prevents a duplicate naming conflict

* Allow for proper null value handling in custom CastsAttributes implementations

* Fix codestyle issue in EloquentModelCustomCastingTest.php
# Conflicts:
#	CHANGELOG-8.x.md
#	src/Illuminate/Collections/Collection.php
#	src/Illuminate/Foundation/Application.php
#	src/Illuminate/Testing/TestResponse.php
* Support the latest psr/container versions

* Added types
# Conflicts:
#	src/Illuminate/Foundation/Application.php
* Implement Symfony Mailer

* Apply fixes from StyleCI

* Update src/Illuminate/Mail/Message.php

Co-authored-by: michael-rubel <contact@observer.name>

* Update src/Illuminate/Mail/Message.php

Co-authored-by: michael-rubel <contact@observer.name>

* Update src/Illuminate/Mail/Message.php

Co-authored-by: michael-rubel <contact@observer.name>

* Update src/Illuminate/Mail/Message.php

Co-authored-by: michael-rubel <contact@observer.name>

* Update src/Illuminate/Mail/Message.php

Co-authored-by: michael-rubel <contact@observer.name>

* Update Array and Log transports

* Apply fixes from StyleCI

* Fix interface implementation

* Update Mailer

* Apply fixes from StyleCI

* Rename

* Remove method

* Fix tests

* Apply fixes from StyleCI

* Work on Mailer tests

* type-hint

* Fix Mailer tests

* Fix more tests

* Apply fixes from StyleCI

* Migrate Mailgun transport

* Migrate Postmark transport

* Replace SesTransport

* Remove transports from dev dependencies

* Allow setting options on esmtp transport

* Fix Postmark transport

* Fix embedding files

* Clarify API transports

* Apply fixes from StyleCI

* Fix SES transport setup

* Add MessageStreamId to Postmark Transport again (#38748)

* Update symfony mailer docblocks (#38773)

* Update docblocks from Swift Mailer to Symfony Mailer

* Make TransportInterface more specific

* Add Session Token to SES Transport (#38797)

* Update src/Illuminate/Mail/Transport/ArrayTransport.php

Co-authored-by: Julius Kiekbusch <jubeki99@gmail.com>

* fix docblock

* Add Wrapper for Symfony SentMessage (#38803)

* Create SentMessage wrapper for Symfony's SentMessage

* Wrap Symfony SentMessage

* Update Docblocks to Illuminate\Mail\SentMessage

* Fix sendMailable

* Update SentMessage.php

Co-authored-by: Dries Vints <dries@vints.io>

Co-authored-by: Taylor Otwell <taylorotwell@users.noreply.github.com>
Co-authored-by: michael-rubel <contact@observer.name>
Co-authored-by: Julius Kiekbusch <jubeki99@gmail.com>
Co-authored-by: Taylor Otwell <taylor@laravel.com>
Co-authored-by: Taylor Otwell <taylorotwell@gmail.com>
[9.x] Fixes invalid PHPDoc syntax
* Update psr/log

* Add types for LogManager

* Update Logger typing
@felixdorn felixdorn closed this Sep 19, 2021
@felixdorn felixdorn reopened this Sep 19, 2021
@felixdorn felixdorn closed this Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.