-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.x] Support AWS SES with IAM Assume Role #40649
Conversation
Looks like I can either get it to work on Windows or Linux, but not both 👀 |
It seems like you are right. Symfony only supports settings these options via the Header: There are four possible solutions going forward:
@driesvints @taylorotwell what are your opinions on that? |
I'll have a look at this today. Thanks |
This can already be merged to address 1. and I'll have a look at the other two. Thanks @deleugpn! |
On PR #38481, the file https://github.com/laravel/framework/blob/3234a8dfecbb12140e1ce980e415fcd0363f320a/tests/Mail/MailSesTransportTest.php was removed and with it 3 features were lost:
This PR addresses point 1. Upon closer look at item 2), it looks quite complex to get that functionality back because it must be configured at Mail Sending time (see symfony/symfony#37897) and during the Mailable build we would end up needing some sort of
if (... instanceof Ses)
.Item 3) seem to not even be supported by Symfony and is not clearly documented by AsyncAws (see https://async-aws.com/clients/ses.html).