[9.x] Re-implement original SesTransport #40696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
|
Ping @deleugpn ^ |
|
@driesvints Can you mark this as ready when you are able to test it manually? |
|
I will try this out on Monday and provide feedback. Thank you so much for the work! |
|
This implementation works really well. It correctly configures the ConfigurationSet and also keep Tags working. The transition from Laravel 8 to this change appears to be seamless to the developer. |
deleugpn
reviewed
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #40685
This PR re-implements the old SesTransport again. All features should work again except the swift mailer specific ones.
Here's the original SesTransport: https://github.com/laravel/framework/blob/8.x/src/Illuminate/Mail/Transport/SesTransport.php
I've also removed the addition of Message ID's to the headers of the sent message afterwards since Symfony mailer now takes care of generating this.
I have not been able to manually test this out yet.