Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows compatible posix_kill method #284

Closed
yes8080 opened this issue Jan 27, 2018 · 2 comments
Closed

Windows compatible posix_kill method #284

yes8080 opened this issue Jan 27, 2018 · 2 comments

Comments

@yes8080
Copy link

yes8080 commented Jan 27, 2018

  1. Remove "ext-posix": "*",from composer.json
  2. Change line 93 of the src/Console/PurgeCommand.php file to
            if (function_exists('posix_kill')) {
                posix_kill($processId, SIGTERM);
            } elseif (function_exists('exec') && strstr(PHP_OS, 'WIN')) {
                exec("taskkill /F /PID $processId") ? TRUE : FALSE;
            }

andsrc/Console/ContinueCommand.php src/Console/PauseCommand.php src/Console/TerminateCommand.php

@mfn
Copy link
Contributor

mfn commented Feb 13, 2018

Remove "ext-posix": "*",from composer.json

This would miss then the proper requirements (at least for the system supporting it).

What is the proper composer declaration so this works for both Unix/Windows environments?

@driesvints
Copy link
Member

Closing this in favor of #170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants