Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedisJobRepository::findFailed() includes successful jobs #340

Closed
garando opened this issue May 11, 2018 · 1 comment
Closed

RedisJobRepository::findFailed() includes successful jobs #340

garando opened this issue May 11, 2018 · 1 comment
Labels

Comments

@garando
Copy link

garando commented May 11, 2018

What I'm trying to implement: I want to dispatch job only if another job with the same tag isn't running already. Unfortunately, I haven't found such method in this framework, so I'm trying to implement it myself using Horizon's services. I would be glad if you point me how I am supposed to do it the right way.

A bug I found: I took job IDs from TagRepository and now I'm trying to check if this job is failed. I supposed that RedisJobRepository::findFailed() will return job only if it's failed and return null otherwise. However, right now it seems to just return job by ID regardless of its status.

@driesvints
Copy link
Member

I believe you're right and that this indeed isn't correct. I'll try to have a look at a later time to see if this can be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants