-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MorphMany in Tab group not working on Safari #6636
Comments
I also just realized that my example has a MorphOne() in the User model but the User resource had MorphMany(). I corrected this outside of the reproduction repo and I am still experiencing the same issue after adjusting the relationship defined in the User model. |
PS thanks for adding tabs, I am very very excited to utilize them and quite excited to see the detail page design progression out of the box continue to improve! |
@crynobone, the screenshot above is for a MorphOne, please attempt using MorphMany. I also wonder if the situation only occurs with multiple tabs. Let me check my reproduction changes again (likely tomorrow PST). |
Please check your reproducing repository https://github.com/ryangurn/nova-reproduce-repo/blob/main/app%2FModels%2FUser.php#L52 also it's missing Note resource class and MorphMany field in User resource |
@ryangurn @crynobone if relationship field's collapsed status has been saved in browser's local storage and then you put them in new "tabs" panel introduced in Nova 5.0+, they will be hidden. you can clear browser storage cache for the site to fix it. |
If that the case here, both Safari and Chrome would have the same behavior. |
@ryangurn you can make sure if this is the bug or not with clearing the safari's local storage for the site |
Using private browsing and ensuring the everything is consistently using MorphMany appears to have resolved the issue. I thought this might be a bug but alas turns out it was just some strange caching on my end. |
Description:
When using a
Tab::group()
with a MorphMany nova relationship within the group as mentioned in the documentation, the panel does not show up in Safari. Things work as expected within Chrome 131.0.6778.205.The above code example is not from my testing repo however I was able to replicate the same issue in the separate repo linked and using the
App\Models\User
model/resource and theApp\Models\Note
model/resource.Safari Screenshot
Chrome Screenshot
Detailed steps to reproduce the issue on a fresh Nova installation:
The text was updated successfully, but these errors were encountered: