Query Logs are recorded in a static array, causes memory leaks

[nazmulpcc]

• Octane Version: 1.0.12
• Laravel Version: 8.62.0
• PHP Version: 8.0.11
• Server & Version: Swoole 4.6.7
• Database Driver & Version: sqlite/mysql

Description:

I was using DB::enableQueryLog() and DB::getQueryLog() to record queries in a request and later process them(automatically find duplicate queries and others). But when I tried to integrate octane, I found that the queries are kept in a array between octane requests. Octane should clear this array after each requests to prevent memory leaks.

Reason

The array is defined in Illuminate/Database/Connection.php#L148, as the Database connection is reused between octane requests, the array on the object is never cleared.

Possible Solution

Maybe octane can call DB::flushQueryLog() after each request? [ For simplicity I am assuming only one connection is used ]

Steps To Reproduce:

• Clone this repo
• Run composer install && cp .env.example .env && touch database/database.sqlite && php artisan migrate. The project is set up to use sqlite as DB driver by default for testing convenience.
• Run php artisan octane:start to start the server and then visit the homepage. After each refresh, you will see that the queries from all previous requests are also present. Also, the property database_connection_object_id in the response shows the current database connection object id which remains same.

[driesvints]

@nazmulpcc Thanks. Your solution sounds reasonable. Can you send in a PR?

[nazmulpcc]

Sure, I will send in a PR soon.

[driesvints]

Thanks @nazmulpcc