Dockerized laravel app exits on passport:keys artisan command

[Sanguigui]

• Passport Version: 10.3.3
• Laravel Version: 8.83.5
• PHP Version: 7.3
• Database Driver & Version:

Description:

Upgrading to version 10 of passport causes my docker container to exit because the command passport:keys returns a 0 or a 1.

In docker a return of 0 means "Absence of an attached process in the foreground" and 1 means "failure due to application error".
It seems this has been added as part of a PR #1509 to update tests and wasn't present in the previous version.

Steps To Reproduce:

I unfortunately couldn't show any code but you could try:

• Dockerize a Laravel v8 app
• Add Passport v10 to it
• Follow documentation's instruction up until deploying passport and running the artisan command passport:keys

[driesvints]

Unsure what you mean as I've always knows 0 to be a success code and 1 to be a failure. The current code seems correct to me.

[Sanguigui]

I don't think it is incorrect, I think this is a side effect to the adding af the return statement.
I was surprised return statements were added where they weren't any before.

In my config on starting the container I use an entrypoint to execute a few php commands, this is why docker reads the return statement.

With few more tests it is failing because it is returning a 1 when keys are already there. We were using the passport:keys command to generate keys if none are there, I guess I'll have to check key existence before running the command now

[driesvints]

I really don't see an issue sorry.

[Sanguigui]

I guess my mistake for using the passport:keys error output when a key exists as a test