Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to new moontoast/math package #815

Closed
buismaarten opened this issue Jan 25, 2020 · 12 comments
Closed

Switch to new moontoast/math package #815

buismaarten opened this issue Jan 25, 2020 · 12 comments

Comments

@buismaarten
Copy link

When I install Laravel Telescope I get the following warning:
Package moontoast/math is abandoned, you should avoid using it. Use brick/math instead.

@driesvints
Copy link
Member

Feel free to send in a PR.

@klimov-paul
Copy link

Note that "laravel/telescope" itself does not use "moontoast/math" directly - it is used by "ramsey/uuid", which is required by "laravel/framework" for UUID generation.

In "ramsey/uuid" "moontoast/math" is an optional requirement, that is why it is added to "require" composer section of "laravel/telescope".

At the present state "ramsey/uuid" has already switched to "brick/math", but this changeset is available only as alpha version:
https://packagist.org/packages/ramsey/uuid#4.0.0-alpha1

This issue will stay on hold until "ramsey/uuid" stable "4.x" release.

@driesvints
Copy link
Member

@klimov-paul correct. This probably needs to go to the next version branch.

@klimov-paul
Copy link

Not necessary.
Since "brick/math" is going to become a required part of "ramsey/uuid" instead of recommended, you may replace "moontoast/math": "^1.1" with "ramsey/uuid: ^4.0" once it is released.
It should not cause any BC break.

@driesvints
Copy link
Member

@klimov-paul current version of Telescope allows for Laravel 5.8 & 6.x while we plan to require a minimum of ramsey/uuid ^4.0 in Laravel 7.

@klimov-paul
Copy link

Indeed.
Since Laravel requires "ramsey/uuid": "^3.7" my suggestion will not help.
Still I would consider to "ramsey/uuid": "^4.0" and Framework 6.x minor version instead of waiting until 7.0. But it is your call.

@driesvints
Copy link
Member

Hmm, that may be possible yeah. I quickly went through https://github.com/ramsey/uuid#upgrading-from-3x-to-4x but I can't immediately see breaking changes for us.

@lomotech
Copy link

Any update about this? Since laravel 7.3 can using ramsey/uuid:4.0 already or did we have any issue that I'm missing.

@driesvints
Copy link
Member

@lomotech we're open to prs.

@driesvints
Copy link
Member

This will be fixed when we eventually release Telescope v4.

@Oluwatobilobaoke
Copy link

Oluwatobilobaoke commented May 14, 2020

hello, @driesvints have you fixed the issue because I'm still receiving the error.
When are you releasing Telescope v4?

@driesvints
Copy link
Member

No plans atm yet. It's just a warning so ignore it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants