Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNSS status reported in correctly #32

Open
degeflija opened this issue Jul 8, 2022 · 2 comments
Open

GNSS status reported in correctly #32

degeflija opened this issue Jul 8, 2022 · 2 comments
Assignees
Labels
invalid This doesn't seem right

Comments

@degeflija
Copy link

While the Single-GNSS on the master sensor board has no GPS-fix (yet), the sensor SW sends a "0" status for the Single-GNSS. That is semantically incorrect, as the GNSS devoce is up and works correctly. So the status should be send as "1". The fact that the Single-GNSS has no fix yet should be properly reported in the CAN packet
c_CID_KSB_GPS_Sats = 0x10a, //!< uint8_t No of Sats
//!> uint8_t Fix-Type NO=0 2D=1 3D=2 RTK=3

@degeflija degeflija added the bug Something isn't working label Jul 8, 2022
@MaxBaex
Copy link
Member

MaxBaex commented Mar 25, 2023

@degeflija : Da scheint sich etwas geändert zu haben. In p.data_b[1] = x.c.sat_fix_type; sind jetzt die ersten beiden Bits relevant. Bedeutung von sat_fix_type Werte:

  • 0 => kein Fix
  • 1 => einfachen Fix
  • 2 => DGNSS Heading Fix

Was fehlt dir da noch?

@degeflija
Copy link
Author

@MaxBaex
There is a difference between the contents of CAN Packets
c_CID_KSB_SystemState
and
c_CID_KSB_GPS_Sats

c_CID_KSB_SystemState sends a bit-mask with each bit representing an operational device on the sensor board.
c_CID_KSB_GPS_Sats sends a number as you described above.

My complaint was about the first CAN Packet.
The sensor did send / sends a 0 bit if the GNSS (any GNSS) has no fix, even as the GNSS device itself was/is properly working.
If the GNSS is operational (working) it should send a 1 bit.
Device operational availibity and operational status are two different things.
CAN packet c_CID_KSB_SystemState was (still is??) faulty, CAN packet c_CID_KSB_GPS_Sats is correct.

@Simsys Simsys added invalid This doesn't seem right and removed bug Something isn't working labels May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

4 participants