HCX-39 Allow to pass only some fields into hid.Hydra#updateSubscription method #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sugarfree1
reviewed
Feb 19, 2020
sugarfree1
suggested changes
Feb 19, 2020
sugarfree1
suggested changes
Feb 19, 2020
|
|
||
| if (notEmpty(input.parSubscriptionId)) { | ||
| LinkedHashMap parentSubscription = getSubscription(input.parSubscriptionId) |
There was a problem hiding this comment.
looks like it is not used
There was a problem hiding this comment.
usually you don't need variable parentSubscription in such situations, in ruby it's something like
existingSubscription = existingSubscription.merge(getSubscription(input.parSubscriptionId).slice(:n_customer_id, :n_account_id, :n_doc_id, :n_object_id))
don't you have groovy way for this?
There was a problem hiding this comment.
There is subMap method in groovy which can be used for this.
But input arguments of updateSubscription have different names from output of SELECT - compare subscriptionId and n_subscription_id. And there is no way easier than currently one to convert them properly.
|
resolve conflicts |
sugarfree1
suggested changes
Feb 20, 2020
sugarfree1
suggested changes
Feb 21, 2020
|
|
||
| if (notEmpty(input.parSubscriptionId)) { | ||
| LinkedHashMap parentSubscription = getSubscription(input.parSubscriptionId) |
There was a problem hiding this comment.
usually you don't need variable parentSubscription in such situations, in ruby it's something like
existingSubscription = existingSubscription.merge(getSubscription(input.parSubscriptionId).slice(:n_customer_id, :n_account_id, :n_doc_id, :n_object_id))
don't you have groovy way for this?
|
Any updates? |
sugarfree1
suggested changes
Mar 4, 2020
sugarfree1
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.