HCX-10 Add custom fields in create and update in PlanadoV2 class

[mxsmirnoff]

No description provided.

[dolfinus]

This requires to pass custom fields as list:

Map newJob = planadl.createJob(
  templateId: ...,
  clientId: ...,
  customFields: [[
    name: 'someField',
    value: 'Some value'
]])

But it's really more convenient better to pass custom fields as Map:

Map newJob = planadl.createJob(
  templateId: ...,
  clientId: ...,
  customFields: [
    someField: 'Some value'
])

It's how current integration with OTRS or Hydra's REST API working

[sugarfree1]

We have list of hashes in Planado REST, why don't we pass it? (Option 1)

[sugarfree1]

@dolfinus, if option 1 works properly then we use it

[dolfinus]

Current solution is not really wrong or not working, but I think if we are making connectors classes which are going to help with implementing new business processes:

1. They should not be just wrappers on API calls without any logic. If you need to call some API at once, you can simply use HTTPRestProcessor and pass everything you want as body or query arg.
2. [key: value] as a way to pass custom fields which is used in all classes of this project. It's quite strange to see in one of them another approach. It's better to have some similarities between different connectors for faster learning.

[sugarfree1]

okay, maybe we do it next time

[dolfinus]

Why next time?

[sugarfree1]

thanks a lot for your help with our codebase, let it go now