HCX-50 Add Jasper report connector #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GideonEXE
force-pushed
the
HCX-50
branch
2 times, most recently
from
e47b2c4 to
f40a152
Compare
GideonEXE
changed the title
TimAle
requested changes
Jun 17, 2020
pom.xml
Outdated
| <version>${ktor.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.koin</groupId> |
| import io.ktor.client.engine.apache.Apache | ||
| import io.ktor.client.features.auth.Auth | ||
| import io.ktor.client.features.auth.providers.* | ||
| import io.ktor.client.statement.HttpResponse |
Comment on lines
12
to
13
| import io.ktor.client.features.defaultRequest | ||
| import io.ktor.http.HttpMethod |
| package org.camunda.latera.bss.HttpClient | ||
|
|
||
| import io.ktor.client.request.* | ||
|
|
| return HttpClient(MockEngine) { | ||
| engine { | ||
| addHandler { request -> | ||
| println(request.url.fullPath) |
| } | ||
| "/reportExecutions" -> { | ||
| val responseHeaders = headersOf("Content-Type" to listOf(ContentType.Application.Json.toString())) | ||
| respond("{\"currentPage\":1,\"exports\":[{\"id\":\"html\",\"status\":\"queued\"}],\"reportURI\":\"/supermart/details/CustomerDetailReport\",\"requestId\":\"f3a9805a-4089-4b53-b9e9-b54752f91586\",\"status\":\"execution\"}", headers = responseHeaders) |
There was a problem hiding this comment.
don't we have any more pretty/convenient way to describe the response?
| val requestId: String, | ||
| val status: String) | ||
|
|
||
| class JasperReport(val jasperUrl: String, val jasperUser: String, val jasperPassword: String) { |
There was a problem hiding this comment.
not sure you should precede every param with jasper, it's kinda obvious
|
|
||
| class JasperReport(val jasperUrl: String, val jasperUser: String, val jasperPassword: String) { | ||
| fun executeReport(params: executeReportParams) : executeReportResponse { | ||
| val jasperUrl = "${this.jasperUrl}/reportExecutions" |
test/kotlin/JasperTest.kt
Outdated
Comment on lines
26
to
31
| assertThat(result.currentPage).isEqualTo(1) | ||
| assertThat(result.reportURI).isEqualTo("/supermart/details/CustomerDetailReport") | ||
| assertThat(result.requestId).isEqualTo("f3a9805a-4089-4b53-b9e9-b54752f91586") | ||
| assertThat(result.status).isEqualTo("execution") | ||
| assertThat(result.exports[0].id).isEqualTo("html") | ||
| assertThat(result.exports[0].status).isEqualTo("queued") |
|
|
TimAle
requested changes
Jun 23, 2020
Comment on lines
20
to
24
| data class executeReportParams(val reportUnitUri: String, | ||
| val parameters: Map<String, Any>, | ||
| val outputFormat: String = "pdf", | ||
| val freshData: Boolean = false, | ||
| val saveDataSnapshot: Boolean = false, |
There was a problem hiding this comment.
Let's capitalize data class names
also there is enough place to land my plane :)
,.
___( |___
`--- \---'
| \
\ \
__________________\ \___________________
\ \ \
------------------ \-------------------
(\) \ \ (\)
\ ' \
:`(.)-'
` ; `,
|
|
||
| class JasperReport(val url: String, val user: String, val password: String) { | ||
| fun executeReport(params: executeReportParams) : executeReportResponse { | ||
| val executeReportUrl = "${this.url}/reportExecutions" |
There was a problem hiding this comment.
We can have trailing slash in this.url, so let's use any URL builder to avoid duplicated slash.
|
|
TimAle
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.